-
Notifications
You must be signed in to change notification settings - Fork 29
feat(cli scaffold): allow deprecated flags #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli scaffold): allow deprecated flags #789
Conversation
imiric
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Could we also add a test for this in cmd_test.go?
That's a good point @imiric , I didn't check this file. I will try to add a unit test for this part of the code. |
kobajagi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
84e780c to
bb5921d
Compare
pierre-emmanuelJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good with test, thanks
Description
This Pr allows developers to deprecate flags in the cli
Checklist
(For exoscale contributors)
Testing