fix: translate xp path if using SSHStateProvider#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ends fixing #213 by providing xp path translation when using SSHStateProvider.
Summary of Changes
translate_path(path: Path) -> strto the StateProvider base class. This provides a standard way toconvert internal filesystem paths into user-facing display paths.
SSHStateProviderClient. It now automatically detects if a path resides within the local SSH cache and translates it back to the corresponding path in the remote_workspace.where pressing 'f' would copy a temporary local cache path instead of the actual remote path.
get_display_path(used by Tasks) to use this new centralized translation logic, ensuringconsistent behavior across all TUI components.
These changes ensure that "Copy Path" always returns a meaningful path to the user, regardless of whether the experiment is running locally or on a remote cluster.