Skip to content

Fixed implicit nullable on php8.4+ #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indykoning wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed implicit nullable on php8.4+ #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Model/Resolver/AddressDetails.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ public function resolve(
Field $field,
$context,
ResolveInfo $info,
array $value = null,
array $args = null
?array $value = null,
?array $args = null
) {

if (!isset($args['context']) || !$args['context']) {
Expand Down
6 changes: 3 additions & 3 deletions Model/Resolver/Autocomplete.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?php
ull<?php

/**
* A Magento 2 module named Experius/Postcode
Expand Down Expand Up @@ -53,8 +53,8 @@ public function resolve(
Field $field,
$context,
ResolveInfo $info,
array $value = null,
array $args = null
?array $value = null,
?array $args = null
) {
if (!isset($args['countryId']) || !$args['countryId']) {
throw new GraphQlInputException(__('"countryId" should be specified'));
Expand Down
4 changes: 2 additions & 2 deletions Model/Resolver/Postcode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ public function resolve(
Field $field,
$context,
ResolveInfo $info,
array $value = null,
array $args = null
?array $value = null,
?array $args = null
) {
if (!isset($args['postcode']) || !$args['postcode']) {
throw new GraphQlInputException(__('"postcode" should be specified'));
Expand Down