feat: add declaration support - #868
Open
sophiathedev wants to merge 3 commits into
Open
Conversation
Resolve behaviour callbacks, protocol functions, and overridable definitions through textDocument/declaration. Closes expert-lsp#145
Normalize path separators before comparing callback source paths on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
textDocument/declarationsupport for behaviour callbacks and protocol functionsTesting
mix test --warnings-as-errorsinapps/engine(1169 passed, 19 excluded)mix test --warnings-as-errorsinapps/expert(843 passed, 12 excluded)mix format --check-formatted,mix credo, andmix dialyzerin both appsCloses #145