fix: use host resolution to check internet - #870
Open
doorgan wants to merge 1 commit into
Open
Conversation
Using a direc DNS query causes false negatives in windows
doorgan
marked this pull request as ready for review
September 1, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a direct DNS query causes false negatives in windows
Should fix #861, what I reproduced from that issue on my windows machine is that the connectivity check would incorrectly fail and
mix local.hexwould be skipped, causingmix loadpathsto hang.This does not happen in stable because it doesn't include the changes to further isolate the mix homes for the engine build and the project builds, and because we no longer try to always force install hex/rebar