fix: read beam binary directly instead of using Module functions - #876
Open
doorgan wants to merge 1 commit into
Open
fix: read beam binary directly instead of using Module functions#876doorgan wants to merge 1 commit into
doorgan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#856 introduced
Module.definitions_inin the tracer(later moved to the tracebuffer). That function's docs specify that "This function can only be used on modules that have not yet been compiled". We cannot guarantee in the tracebuffer that the module was not yet been compiled, so we can't use that function. Also we already have the module binary available, so we should be reading that instead anyways.This PR removes that function and reads the module binary for definitions like we do in the rest of the codebase.