Skip to content

[expo-cocoapods-proxy] Bump bundler to fix compatibility with RubyGems 4 - #3824

Merged
gwdp merged 8 commits into
mainfrom
gwdp/fix-cocoapods-proxy-bundler
Jun 8, 2026
Merged

gwdp merged 8 commits into
mainfrom
gwdp/fix-cocoapods-proxy-bundler

Conversation

@gwdp

@gwdp gwdp commented Jun 5, 2026 •

Copy link
Copy Markdown
Contributor

Why

iOS worker tarball builds started failing on the new macOS Tahoe image. Failing run: https://expo.dev/accounts/expo/projects/eas-worker/workflows/019e99b9-9621-72be-bc71-086f6b5fe87c

The new Tahoe image ships ruby@3.2 with RubyGems 4.x, which removed Gem::Platform.match. Bundler 2.1.4 calls it unconditionally:

NoMethodError: undefined method `match' for Gem::Platform:Class
  bundler-2.1.4/lib/bundler/index.rb:198

The previous Sequoia image had an older ruby@3.2 where match still existed (deprecated), so it passed with warnings.

How

  • Bumped bundler dev dependency from ~> 1.17 to >= 2.4 in the gemspec — bundler 2.2+ uses match_gem? instead
  • Regenerated Gemfile.lock (BUNDLED WITH 2.1.4 → 4.0.13)
  • Added .github/workflows/trigger-worker-build.yml — builds the worker tarball on PRs touching packages/worker or packages/expo-cocoapods-proxy, and available as a manual dispatch

Note: bundle install only runs at tarball build time on image: latest, not on customer machines, so this is safe across all worker images.

Test Plan

  • Reproduced locally — bundle install under modern Ruby/RubyGems errors before the fix, passes after
  • This PR should trigger the new worker build CI check

@codecov

codecov Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.23%. Comparing base (58982ee) to head (99e5fa4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3824      +/-   ##
==========================================
+ Coverage   58.04%   58.23%   +0.20%     
==========================================
  Files         917      916       -1     
  Lines       39767    39727      -40     
  Branches     8329     8324       -5     
==========================================
+ Hits        23079    23133      +54     
+ Misses      15237    15159      -78     
+ Partials     1451     1435      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp requested a review from sjchmiela June 5, 2026 22:45
@gwdp
gwdp marked this pull request as ready for review June 5, 2026 22:48
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Comment thread .github/workflows/trigger-worker-build.yml Outdated
@hSATAC

hSATAC commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

I think my release failed due to the same issue.

I'll wait for this to be merged.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@gwdp
gwdp merged commit d8cca2c into main Jun 8, 2026
10 checks passed
@gwdp
gwdp deleted the gwdp/fix-cocoapods-proxy-bundler branch June 8, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants