Repository navigation
Conversation
|
/changelog-entry bug-fix [eas-cli] Update the bundled Expo config stack so TypeScript app.config.ts files work with import.meta and TypeScript 7. |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
068422f to
0204acc
Compare
0204acc to
34c399f
Compare
4e1338e to
148d77e
Compare
148d77e to
f89caa2
Compare
…stream-sync # Conflicts: # packages/eas-cli/package.json # yarn.lock
|
Updated this PR's branch with current |
|
Follow-up: I added a focused regression test in commit The new head still has four GitHub Actions workflows marked |
Why
Fixes #4205.
EAS CLI currently bundles an older Expo config-loading stack that can fail to read valid TypeScript
app.config.tsfiles in two cases:import.metacan fail when the bundled fallback is evaluated as CommonJStypescriptpackage stub, so the older require-utils path dereferences a missingModuleKind.CommonJSThe SDK 56 config stack already contains the fixes for both cases.
How
@expo/config@56.0.14@expo/config-plugins@56.0.16@expo/prebuild-config@56.0.23@expo/require-utils@56.1.7splashvalidation read after the SDK 56 config type changeresolveFrom-based config path resolutionyarn.lockTest Plan
The original validation run on the pre-refresh branch passed the TypeScript 7 and
import.metareproductions, workspace build, fallback and exempt-encryption tests, typecheck, formatting, lint, and all 325 Jest suites: https://github.com/erenbati/eas-cli/actions/runs/34762593768After merging current upstream
mainatf949f34(head6675cdd):corepack yarn workspace eas-cli typecheck-for-buildpassedcopy-new-templatesbut itsmkdir -pcommand is not supported by the Windows shellaction_required); they have not run on this headChecklist