Skip to content

Upgrade typescript to highest 5.x - #4399

Merged
wschurman merged 1 commit into
mainfrom
09-14-upgrade_typescript_to_highest_5.x
Sep 17, 2026
Merged

wschurman merged 1 commit into
mainfrom
09-14-upgrade_typescript_to_highest_5.x

Conversation

@wschurman

@wschurman wschurman commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Why

This is a bit behind in typescript. 6.x is where most of our repos live.

First step is to get to highest 5.x.

How

Tell claude to upgrade to highest 5.x.

It required a new version of https-proxy-agent to be compatible with new node types.

Test Plan

yarn start, tests.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.30%. Comparing base (c7b3105) to head (c3bb459).

Files with missing lines Patch % Lines
packages/eas-cli/src/build/createContext.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/fetch.ts 50.00% 1 Missing ⚠️
packages/eas-cli/src/uploads.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/worker/upload.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4399      +/-   ##
==========================================
+ Coverage   72.29%   72.30%   +0.01%     
==========================================
  Files         970      970              
  Lines       46133    46132       -1     
  Branches     9903     9902       -1     
==========================================
  Hits        33349    33349              
+ Misses      11789    11788       -1     
  Partials      995      995              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman
wschurman marked this pull request as ready for review September 14, 2026 18:44
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder
packages/eas-cli/src/worker/** @kitten, @kadikraman
packages/eas-cli/src/build/** @sjchmiela

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@wschurman
wschurman force-pushed the 09-14-upgrade_typescript_to_highest_5.x branch from fefa1be to c3bb459 Compare September 17, 2026 17:09
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@wschurman
wschurman merged commit 1677efc into main Sep 17, 2026
13 checks passed
@wschurman
wschurman deleted the 09-14-upgrade_typescript_to_highest_5.x branch September 17, 2026 17:17
wschurman added a commit that referenced this pull request Sep 17, 2026
<!-- You can skip the changelog check by labeling the PR with "no changelog". -->

# Why

Follow-up to #4399 to upgrade typescript to latest version. 

# How

Tell claude to upgrade to 6.x.

# Test Plan

CI, tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants