Skip to content

[eas-cli] Add --system-image to eas simulator:start - #4500

Merged
krystofwoldrich merged 1 commit into
mainfrom
t3code/3b0f332d
Oct 20, 2026
Merged

krystofwoldrich merged 1 commit into
mainfrom
t3code/3b0f332d

Conversation

@krystofwoldrich

@krystofwoldrich krystofwoldrich commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add --system-image to select the Android SDK system image for a simulator session.
  • Trim the supplied value, omit blank values, and reject the flag for iOS.
  • Cover forwarding it alone and alongside --device with command tests.

Testing

  • Added command tests for Android forwarding, combined device options, blank values, and iOS rejection.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.30%. Comparing base (e4bb181) to head (da6943f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4500      +/-   ##
==========================================
+ Coverage   75.30%   75.30%   +0.01%     
==========================================
  Files        1053     1053              
  Lines       52170    52177       +7     
  Branches    11356    11362       +6     
==========================================
+ Hits        39281    39289       +8     
+ Misses      11901    11900       -1     
  Partials      988      988              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread CHANGELOG.md Outdated

### 🎉 New features

- [eas-cli] Add a `--system-image` flag to `eas simulator:start` to select the Android SDK system image for the emulator. ([#TBD](https://github.com/expo/eas-cli/pull/TBD) by [@krystofwoldrich](https://github.com/krystofwoldrich))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PR

@douglowder

Copy link
Copy Markdown
Contributor

eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit CHANGELOG.md.

To update this PR:

  1. Revert the changes to CHANGELOG.md.
  2. Run yarn changeset, select the changed packages and the bump type, and write the summary.
  3. Commit the new file in .changeset/.

The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the CHANGELOG.md changes and add the "no changelog" label.

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@krystofwoldrich
krystofwoldrich merged commit 42e4fa8 into main Oct 20, 2026
11 of 13 checks passed
@krystofwoldrich
krystofwoldrich deleted the t3code/3b0f332d branch October 20, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants