Skip to content

[build-tools] Separate Argent and simulator preview logs - #4587

Merged
gwdp merged 1 commit into
gwdp/serve-sim-appium-logsfrom
gwdp/serve-sim-argent-logs
Oct 15, 2026
Merged

gwdp merged 1 commit into
gwdp/serve-sim-appium-logsfrom
gwdp/serve-sim-argent-logs

Conversation

@gwdp

@gwdp gwdp commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Why

Keep Argent controller output and its simulator preview in separate log phases.

How

  • Keep serve-sim output in its own preview phase while the Argent controller step stays active.
  • Stream Argent output into its controller step and redact the discovered tool-server token.
  • Clean up the process, polling and collectors after partial startup failures.

Test Plan

  • Fresh Devin review completed. Its hypothetical early-token finding was resolved with a probe of the published Argent 0.28.0 startup formatter and production redaction; no code change was needed.
  • CI passed on the current head.
  • Local Argent session started through EAS CLI, Universe API/workflow worker and the rebuilt build-tools. The website preview worked with serve-sim 0.6.3 on an iPhone 17 Simulator. Argent 0.28.0 accepted authenticated tool calls through ngrok and read the selected device's UI tree. Controller and serve-sim logs were ingested under separate phases, with both live tokens absent from the captured logs.
Earlier and automated validation

After restacking, Codex ran 66 focused tests and built all 13 EAS packages successfully. Changed-file lint, formatting and changelog validation passed. Claude reviewed the earlier controller slices and found no correctness issues.

Earlier local launch E2E used Universe-generated steps through build-tools download/install/start to serve-sim on a real iOS Simulator, checking one app start, launch arguments and the deep link. Those runs used loopback adapters for cloud tunnel/reporting calls and a pinned local serve-sim build/device; they cover earlier heads. The current Argent run used the real local Universe worker and ngrok. Hosted EAS/API-to-worker execution remains untested. CI is separate.

Screenshots

Argent controller logs

Simulator preview logs

Authorship and LLM use

Gabe wrote the initial implementation, directed the iterations and requested the split once he was happy with the result. Codex made fixes, split the PRs, restacked this branch and updated this description; Claude and Devin reviewed the broader work. The reviews led to redaction and shutdown refinements. Gabe reviewed the final code through #4601, including this Argent diff. Local Argent validation is described above; hosted execution remains untested.

@gwdp

gwdp commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex separated Argent and simulator-preview logging, preserved token redaction and startup cleanup, and restacked this layer under Gabe's direction. Gabe reviewed the final code through #4601, including this Argent diff. Current-head CI is green. Earlier local Argent/website validation and screenshots are preserved; hosted execution was not tested.

The hypothetical early-token finding was resolved with a probe of the published Argent 0.28.0 startup formatter and production redaction; no code change was needed.

— Codex

@codecov

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-argent-logs branch from 9f3ee9c to 06729a5 Compare October 9, 2026 19:49
@gwdp
gwdp force-pushed the gwdp/serve-sim-argent-logs branch from 06729a5 to 8189138 Compare October 9, 2026 23:32
@gwdp
gwdp added this pull request to stack #4599 October 10, 2026 00:26
@gwdp
gwdp removed this pull request from stack #4599 October 10, 2026 08:38
@gwdp
gwdp added this pull request to stack #4604 October 10, 2026 08:40
@gwdp
gwdp removed this pull request from stack #4604 October 10, 2026 16:54
@gwdp
gwdp added this pull request to stack #4606 October 10, 2026 16:55
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as outdated.

@gwdp
gwdp marked this pull request as ready for review October 10, 2026 18:52
@gwdp
gwdp requested a review from szdziedzic October 10, 2026 18:52
@douglowder

Copy link
Copy Markdown
Contributor

eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit CHANGELOG.md.

To update this PR:

  1. Revert the changes to CHANGELOG.md.
  2. Run yarn changeset, select the changed packages and the bump type, and write the summary.
  3. Commit the new file in .changeset/.

The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the CHANGELOG.md changes and add the "no changelog" label.

@gwdp

gwdp commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Rebased this layer onto gwdp/serve-sim-appium-logs and moved its release note from CHANGELOG.md into its own changeset. Current-main behavior was preserved.

Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack.

Published head: a037586b8959af5056ebe9aeaf8fb601504ff4ef.

— Codex

@gwdp
gwdp force-pushed the gwdp/serve-sim-argent-logs branch 3 times, most recently from 2ff0e63 to 0c21120 Compare October 15, 2026 05:09
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@gwdp
gwdp force-pushed the gwdp/serve-sim-argent-logs branch from 0c21120 to 255be36 Compare October 15, 2026 16:15
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp
gwdp merged commit 219df86 into main Oct 15, 2026
10 checks passed
@gwdp
gwdp deleted the gwdp/serve-sim-argent-logs branch October 15, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants