Skip to content

[build-tools] Polish some Google Play submission messages - #4625

Merged
sjchmiela merged 4 commits into
mainfrom
stanley/google-play-submission-messages
Oct 15, 2026
Merged

sjchmiela merged 4 commits into
mainfrom
stanley/google-play-submission-messages

Conversation

@sjchmiela

@sjchmiela sjchmiela commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

I want to polish Google Play submission messages a bit.

How

Tested the code with a few more edge cases and handled them a bit better.

Test Plan

CI should pass.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.44%. Comparing base (6d8c29c) to head (6c176cd).

Files with missing lines Patch % Lines
...ld-tools/src/steps/functions/submitToGooglePlay.ts 90.91% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4625      +/-   ##
==========================================
+ Coverage   74.44%   74.44%   +0.01%     
==========================================
  Files        1029     1029              
  Lines       50357    50370      +13     
  Branches    10875    10884       +9     
==========================================
+ Hits        37481    37493      +12     
  Misses      11886    11886              
- Partials      990      991       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela
sjchmiela added this pull request to stack #4630 October 14, 2026 19:23
@sjchmiela sjchmiela changed the title [build-tools] clarify Google Play submission messages [build-tools] Polish some Google Play submission messages Oct 14, 2026
@sjchmiela
sjchmiela requested a balanced review from Copilot October 14, 2026 19:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sjchmiela
sjchmiela marked this pull request as ready for review October 15, 2026 07:00
@sjchmiela
sjchmiela requested a review from hSATAC October 15, 2026 07:05

@hSATAC hSATAC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI CHANGELOG is gone. follow the instruction to migrate to the new approach.
#4624 (comment)

@sjchmiela
sjchmiela force-pushed the stanley/google-play-submission-messages branch from 9c36552 to 6c176cd Compare October 15, 2026 07:37
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@sjchmiela
sjchmiela merged commit f97e6ec into main Oct 15, 2026
10 checks passed
@sjchmiela
sjchmiela deleted the stanley/google-play-submission-messages branch October 15, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants