Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gwdp
added this pull request to stack #4606
October 17, 2026 00:19
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gwdp
removed this pull request from stack #4606
October 17, 2026 01:44
gwdp
added this pull request to stack #4670
October 17, 2026 01:44
This was referenced Oct 17, 2026
gwdp
force-pushed
the
gwdp/agent-device-startup-stop-20261016
branch
from
October 20, 2026 05:05
509e8de to
7a43ac7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gwdp/supervise-device-session-tunnels #4666 +/- ##
=========================================================================
+ Coverage 75.36% 75.38% +0.02%
=========================================================================
Files 1054 1055 +1
Lines 52323 52359 +36
Branches 11427 11390 -37
=========================================================================
+ Hits 39430 39466 +36
Misses 11904 11904
Partials 989 989 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ Thank you for adding a changeset! |
gwdp
marked this pull request as ready for review
October 21, 2026 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Stop request that arrived while an agent-device session was still starting did not end startup. The worker went on through the build download, Simulator boot, app install and launch, and controller setup, and then reported the session as ready. Hosted Argent QA showed the same gap, so the next PRs in this stack cover Argent, Appium and web preview with the helper that this PR adds.
How
watchDeviceRunSessionStartupinsteps/utils/deviceRunSessionStartup.ts. It polls the session status during startup with the existing status poll. On Stop, it aborts the startup tasks with a "stopped during startup" error. A poll failure aborts startup with that error.completeAsyncends the watch when the session reports ready and throws if startup was aborted.finishAsyncends the watch in cleanup without throwing. Only one status poll runs at a time, because the watch ends before the lifetime wait starts.Test Plan
src/stepstests on this commit (1943 passed, 8 skipped), and the root build, typecheck, oxlint, oxfmt and Lerna tests on the top of the stack (2511 passed, 8 skipped).bf60bca. Codecov reports all changed lines covered.Authorship and LLM use
Gabe directed the approach and excluded artifact-poller changes. Codex wrote the original change and tests. AI review and Devin review found one issue: an errored status was hidden at the duration deadline. That was fixed. Claude Code rebased the PR onto #4526 and adapted the tests to main. On Gabe's request, Claude Code moved the startup watch into a shared helper that the next three PRs reuse. Gabe asked to mark it ready for review. His review of the final diff is pending.
Generated with T3 Code, using Claude Code.