Repository navigation
[build-tools] install the repack package with npm in an isolated sandbox - #4728
Merged
hSATAC merged 1 commit intoOct 28, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4728 +/- ##
==========================================
+ Coverage 75.75% 75.75% +0.01%
==========================================
Files 1059 1061 +2
Lines 52813 52824 +11
Branches 11566 11564 -2
==========================================
+ Hits 40001 40011 +10
- Misses 11832 11833 +1
Partials 980 980 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Kudo
approved these changes
Oct 27, 2026
| } from '@expo/steps'; | ||
| import { randomUUID } from 'node:crypto'; | ||
| import fs from 'node:fs'; | ||
| import fs from 'fs-extra'; |
Contributor
There was a problem hiding this comment.
personally lean toward to not using fs-extra more. either use
fs/promises+ JSON.parse@expo/json-file
Contributor
Author
There was a problem hiding this comment.
Thanks, I didn't notice we're removing fs-extra. Will address this.
Contributor
There was a problem hiding this comment.
it's just something we have been trying to achieve in expo/expo. fewer dependencies would reduce the dependency chain attack
hSATAC
force-pushed
the
ash/eng-28285-easrepack-installs-exporepack-app-with-a-hard-coded-yarn-add
branch
from
October 28, 2026 08:59
15e6358 to
cd4886c
Compare
|
✅ Thank you for adding a changeset! |
hSATAC
deleted the
ash/eng-28285-easrepack-installs-exporepack-app-with-a-hard-coded-yarn-add
branch
October 28, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas/repackinstalls@expo/repack-appwith a hard-codedyarn addthat runs with the build machine's npm/Yarn config and no logger. A~/.npmrcwritten by a build hook made the install fail with the error hidden from the build log, and nothing in the step could keep that config out.How
installIsolatedNpmPackageAsyncto install one npm package with an env of onlyPATHand a freshHOME, shared with the agent CLI install.utils/npmCacheRegistry.ts.npm viewversion lookup and report the installed version from the package'spackage.json.Test Plan
Added unit coverage for the isolated install, the cache fallback and the no-retry cases, and kept the agent-run tests pinning the same npm arguments. Also ran lint, format and TypeScript checks, and verified locally that a poisoned
~/.npmrcno longer reaches the install.