Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4737 +/- ##
==========================================
+ Coverage 75.55% 75.79% +0.24%
==========================================
Files 1053 1054 +1
Lines 52399 52423 +24
Branches 11442 11445 +3
==========================================
+ Hits 39587 39729 +142
+ Misses 11831 11729 -102
+ Partials 981 965 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sjchmiela
force-pushed
the
stanley/asc-processing-step
branch
from
October 24, 2026 09:29
ff25dca to
7511d84
Compare
sjchmiela
changed the base branch from
main
to
stanley/asc-processing-timeout
October 24, 2026 09:29
sjchmiela
added this pull request to stack #4739
October 24, 2026 09:29
sjchmiela
removed this pull request from stack #4739
October 24, 2026 09:34
sjchmiela
changed the base branch from
stanley/asc-processing-timeout
to
main
October 24, 2026 09:34
sjchmiela
force-pushed
the
stanley/asc-processing-step
branch
from
October 24, 2026 09:37
7511d84 to
bae232a
Compare
sjchmiela
added this pull request to stack #4742
October 24, 2026 15:11
sjchmiela
marked this pull request as ready for review
October 24, 2026 15:39
sjchmiela
removed this pull request from stack #4742
October 24, 2026 15:55
sjchmiela
force-pushed
the
stanley/asc-processing-step
branch
from
October 24, 2026 15:57
a893d85 to
1572a64
Compare
sjchmiela
added this pull request to stack #4747
October 24, 2026 15:57
|
✅ Thank you for adding a changeset! |
sjchmiela
removed this pull request from stack #4747
October 24, 2026 20:11
sjchmiela
added this pull request to stack #4748
October 24, 2026 20:12
sjchmiela
marked this pull request as draft
October 24, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I think it's going to be slightly nicer to remove
wait_for_processingflag and instead have a separate EAS function? Wdyt?How
Related to https://github.com/expo/universe/pull/32740. Moved wait-for-processing to
AscApiUtils, added new EAS function.Test Plan
CI should pass.