Skip to content

[build-tools] Add a separate App Store Connect processing step - #4737

Draft
sjchmiela wants to merge 9 commits into
mainfrom
stanley/asc-processing-step
Draft

sjchmiela wants to merge 9 commits into
mainfrom
stanley/asc-processing-step

Conversation

@sjchmiela

@sjchmiela sjchmiela commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Why

I think it's going to be slightly nicer to remove wait_for_processing flag and instead have a separate EAS function? Wdyt?

How

Related to https://github.com/expo/universe/pull/32740. Moved wait-for-processing to AscApiUtils, added new EAS function.

Test Plan

CI should pass.

@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.87629% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.79%. Comparing base (d02de4d) to head (a893d85).

Files with missing lines Patch % Lines
...ges/build-tools/src/steps/functions/uploadToAsc.ts 60.00% 2 Missing ⚠️
...s/src/steps/functions/waitForAscBuildProcessing.ts 97.76% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4737      +/-   ##
==========================================
+ Coverage   75.55%   75.79%   +0.24%     
==========================================
  Files        1053     1054       +1     
  Lines       52399    52423      +24     
  Branches    11442    11445       +3     
==========================================
+ Hits        39587    39729     +142     
+ Misses      11831    11729     -102     
+ Partials      981      965      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela
sjchmiela force-pushed the stanley/asc-processing-step branch from ff25dca to 7511d84 Compare October 24, 2026 09:29
@sjchmiela
sjchmiela changed the base branch from main to stanley/asc-processing-timeout October 24, 2026 09:29
@sjchmiela
sjchmiela added this pull request to stack #4739 October 24, 2026 09:29
@sjchmiela
sjchmiela removed this pull request from stack #4739 October 24, 2026 09:34
@sjchmiela
sjchmiela changed the base branch from stanley/asc-processing-timeout to main October 24, 2026 09:34
@sjchmiela
sjchmiela force-pushed the stanley/asc-processing-step branch from 7511d84 to bae232a Compare October 24, 2026 09:37
@sjchmiela sjchmiela changed the title [build-tools] add a separate App Store Connect processing step [build-tools] Add a separate App Store Connect processing step Oct 24, 2026
@sjchmiela
sjchmiela added this pull request to stack #4742 October 24, 2026 15:11
@sjchmiela
sjchmiela marked this pull request as ready for review October 24, 2026 15:39
@sjchmiela
sjchmiela requested a review from sswrk October 24, 2026 15:39
@sjchmiela
sjchmiela removed this pull request from stack #4742 October 24, 2026 15:55
@sjchmiela
sjchmiela force-pushed the stanley/asc-processing-step branch from a893d85 to 1572a64 Compare October 24, 2026 15:57
@sjchmiela
sjchmiela added this pull request to stack #4747 October 24, 2026 15:57
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@sjchmiela
sjchmiela removed this pull request from stack #4747 October 24, 2026 20:11
@sjchmiela
sjchmiela added this pull request to stack #4748 October 24, 2026 20:12
@sjchmiela
sjchmiela marked this pull request as draft October 24, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant