Skip to content

[build-tools] Remove ASC upload wait after producer rollout - #4741

Open
sjchmiela wants to merge 1 commit into
stanley/asc-processing-stepfrom
stanley/remove-asc-upload-wait
Open

sjchmiela wants to merge 1 commit into
stanley/asc-processing-stepfrom
stanley/remove-asc-upload-wait

Conversation

@sjchmiela

@sjchmiela sjchmiela commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Why

I think a separate function might be neater than rolling waiting into updating.

How

Added separate function in the PR below. Universe should move over to the new function in https://github.com/expo/universe/pull/32744 so we should be ok to remove it now.

Test Plan

CI should pass.

@sjchmiela
sjchmiela added this pull request to stack #4742 October 24, 2026 15:11
@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.79%. Comparing base (1572a64) to head (ad4ee7b).

Files with missing lines Patch % Lines
...s/src/steps/functions/waitForAscBuildProcessing.ts 96.43% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           stanley/asc-processing-step    #4741      +/-   ##
===============================================================
- Coverage                        75.79%   75.79%   -0.00%     
===============================================================
  Files                             1054     1054              
  Lines                            52421    52416       -5     
  Branches                         11444    11442       -2     
===============================================================
- Hits                             39727    39722       -5     
  Misses                           11729    11729              
  Partials                           965      965              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela changed the title [build-tools] remove processing wait from ASC upload [build-tools] Remove processing wait from ASC upload Oct 24, 2026
@sjchmiela
sjchmiela force-pushed the stanley/remove-asc-upload-wait branch 4 times, most recently from f4dd117 to 6885f35 Compare October 24, 2026 15:47
@sjchmiela
sjchmiela removed this pull request from stack #4742 October 24, 2026 15:55
@sjchmiela
sjchmiela force-pushed the stanley/remove-asc-upload-wait branch from 6885f35 to f4dd117 Compare October 24, 2026 15:57
@sjchmiela
sjchmiela added this pull request to stack #4747 October 24, 2026 15:57
@sjchmiela
sjchmiela removed this pull request from stack #4747 October 24, 2026 20:11
@sjchmiela
sjchmiela force-pushed the stanley/remove-asc-upload-wait branch from f4dd117 to 27b38fa Compare October 24, 2026 20:12
@sjchmiela
sjchmiela changed the base branch from stanley/asc-processing-step to stanley/asc-processing-timeout October 24, 2026 20:12
@sjchmiela sjchmiela changed the title [build-tools] Remove processing wait from ASC upload [build-tools] retire ASC upload wait after producer rollout Oct 24, 2026
@sjchmiela
sjchmiela force-pushed the stanley/remove-asc-upload-wait branch from 27b38fa to ad4ee7b Compare October 26, 2026 10:03
@sjchmiela
sjchmiela changed the base branch from stanley/asc-processing-timeout to stanley/asc-processing-step October 26, 2026 10:03
@sjchmiela
sjchmiela added this pull request to stack #4755 October 26, 2026 10:03
@sjchmiela sjchmiela changed the title [build-tools] retire ASC upload wait after producer rollout [build-tools] Remove ASC upload wait after producer rollout Oct 26, 2026
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@sjchmiela
sjchmiela marked this pull request as ready for review October 26, 2026 10:03
@sjchmiela
sjchmiela requested a review from sswrk October 26, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant