Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
/devin review |
|
Starting Devin Review. |
|
✅ Thank you for adding a changeset! |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+127
to
139
| const error = err instanceof Error ? err : new Error(String(err)); | ||
| listArtifactsErrorCount += 1; | ||
| // The final inventory has no later retry, so always report its failure. | ||
| if (finalInventory || listArtifactsErrorCount % 5 === 0) { | ||
| Sentry.capture('Could not list agent-device remote session artifacts', error); | ||
| logger.warn( | ||
| { err: error, failedArtifactListCount: listArtifactsErrorCount }, | ||
| 'Could not list agent-device remote session artifacts.' | ||
| ); | ||
| } | ||
| } | ||
| } catch (err) { | ||
| if (err instanceof AgentDeviceArtifactsUnsupportedError) { | ||
| logger.warn( | ||
| 'agent-device daemon does not expose artifact inventory; remote session artifact uploads are disabled.' | ||
| ); | ||
| if (finalInventory) { | ||
| return; |
There was a problem hiding this comment.
🔍 Final-pass failures use poller diagnostics
A failed final inventory is logged and sent to Sentry, but its caught error never reaches teardown. The claimed teardown reporting applies only to unexpected poller rejections.
Was this helpful? React with 👍 or 👎 to provide feedback.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4750 +/- ##
==========================================
+ Coverage 75.55% 75.57% +0.02%
==========================================
Files 1053 1053
Lines 52399 52442 +43
Branches 11442 11459 +17
==========================================
+ Hits 39587 39629 +42
- Misses 11831 11832 +1
Partials 981 981 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The agent-device remote session checks the daemon for new artifacts every 5 seconds. When the session stops, the daemon stops right away, so an artifact created after the last check is never uploaded.
How
This PR shares
agentDeviceArtifacts.tsand its test file with #4724. The files are byte-identical, so the diff of #4724 on these files becomes empty after this PR merges.Test Plan
Claude Code ran these checks on bbbdee1: typecheck, lint and format check pass, and build-tools has 2526 tests passed, 8 skipped and 0 failed.
New tests
uploads an artifact created after the last periodic inventory before the daemon stopsstops the daemon when the final artifact drain failsTwo suites that automock the poller now give it a resolved value:
deviceSessionHost-orchestration.test.tsandremoteSessionLocalEgress.test.ts.Authorship and LLM use
Rollback
Revert this PR; the session then stops the daemon without the last upload pass.
Generated with T3 Code, using Claude Code.