Repository navigation
Conversation
…ock readers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
/devin review |
|
✅ Thank you for adding a changeset! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4751 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 1053 1053
Lines 52399 52399
Branches 11442 11442
=======================================
Hits 39587 39587
Misses 11831 11831
Partials 981 981 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sandboxDaemonCommands.test.ts › measures each call separatelyfailed once in CI run 40253762840 withReceived 72.751534592instead of0.25. The test mocks the shared process clock with a queue of two values. Any other code that readsperformance.now()during the call, such as Node's built-infetch, takes one of the values, so the end read gets the real clock: (73,751 − 1,000) / 1,000 = 72.75.How
Test Plan
Claude Code ran these checks on d6651d6: lint, format check and typecheck pass.
fetchruns during the call. The new test passes.Repro counts (Node 22.23.4)
fetchduring the call: main fails 3 of 3; this change fails 0 of 3.Authorship and LLM use
Rollback
Revert this PR; only the test changes.
Generated with T3 Code, using Claude Code.