Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e26e93e to
fe3e508
Compare
5292ee4 to
904e25e
Compare
904e25e to
c28c49b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f726897 to
d0b4157
Compare
d0b4157 to
98a56f8
Compare
|
Codex rebased this PR onto main Current head: Earlier contribution and validationCodex rebased this layer on the current-boot cleanup guard and updated its real cleanup fixture. The cold host still waits immediately before spawning serve-sim. Preview overlap, bounded retirement and cleanup error handling are retained. Fourteen cleanup/cold-start tests pass. The earlier memfs report remains resolved. Current head: ce93127. Local typecheck, scoped lint and formatting pass. Devin analysis passed on this exact head; CI passes on this head. Gabe reviewed the preceding changes; this round and the updated base still need human review. — Codex |
98a56f8 to
a1800b9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a1800b9 to
ce93127
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Edited-by: Codex Edited-by: Codex
…action Edited-by: Codex
ce93127 to
c8ca33a
Compare
|
✅ Thank you for adding a changeset! |
Why
Cold and warm sessions need the same preview, app startup and cleanup steps.
How
Move cold iOS Simulator session startup into
coldIosSession.tsbehind the session host's shared preview, app-start and cleanup contract. #4724 supplies the warm implementation. Android keeps its existing startup.The cold path waits for warm cleanup (#4721) before starting serve-sim. Requires the serve-sim release with port-based adoption.
How the session host and server coordinate
coldIosSession.ts): supplies the port and startup handle, waits for warm cleanup, then starts a fresh serve-sim. It also supplies Simulator-specific setup such as the apsd attempt.The host can use either server without duplicating app and preview handling. Preview opening still overlaps startup. Opening and retirement waits are bounded, late listeners close themselves, and unconfirmed warm tunnel retirement prevents cold fallback. The cleanup wait belongs immediately before cold serve-sim startup because that process boots the Simulator; unrelated session preparation can proceed earlier. Startup rollback attempts server stop and screenshot cleanup; combined startup and cleanup failures retain both causes. Both supported host commands use
--require-token. Android keeps its existing startup implementation.Test Plan
Local focused tests, build-tools typecheck, scoped lint and formatting pass. CI passes on this head; Devin analysis passed.
No fresh native run for this review round.
Earlier verified local launch E2E: Universe-generated steps through build-tools download/install/start to a pinned serve-sim build on a real iOS Simulator; checked one app start, launch arguments and deep link. It used loopback tunnel/reporting adapters and was not rerun for this head. This was local validation, not hosted EAS/API-to-worker acceptance.
Authorship and LLM use
Gabe reviewed the preceding changes. Codex and Claude Code wrote the code and tests. This review round and the updated base still need human review.
Rollback
Revert #4724 and its dependent layers first.
— Codex