Repository navigation
Add composable native visitor selectors - #90
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When applied, these changes let the native side filter visitor matches before preparing callback data or dispatching to JS, reducing unnecessary callbacks on expensive plugins.
defineVisitornow also accepts a selector object with:routeandwhereto select nodes by type and fields.parentto constrain the immediate AST parent.childrento constrain named child roles, with optional listindex.This is backwards-compatible and filed as a patch instead, since we're still in
0.releases.Examples
Conditionals combine in an AND logic and are:
Filter by fields:
Match an immediate parent:
Match a named child, while delivering the root node:
Match a particular list position: