docs: add TypeScript section to express-generator page#2346
Closed
i-afaqrashid wants to merge 1 commit into
Closed
docs: add TypeScript section to express-generator page#2346i-afaqrashid wants to merge 1 commit into
i-afaqrashid wants to merge 1 commit into
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Apologies, I missed the existing #2311 covering the same scope. Closing in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes expressjs/express#7231.
Summary
The Express application generator page does not mention TypeScript. Adds a short
TypeScriptsubsection to the end of the generator docs (both 4x and 5x), noting that the officialexpress-generatoroutputs a JavaScript skeleton and pointing toexpress-generator-typescriptas a community alternative, exactly as suggested in the issue.Scoped narrowly:
src/content/docs/en/4x/starter/generator.mdxandsrc/content/docs/en/5x/starter/generator.mdxso both versions stay in sync.Checks run locally
npm run check(format:check + lint) — cleannpm run build— 1222 pages built, no errorsHappy to expand the section (e.g. a small tsconfig.json or App.ts snippet) if maintainers prefer a heavier addition.