Skip to content

Fix 3 high severity vulnerabilities by upgrading all packages to their lastest version. - #113

Closed
emilioplatzer wants to merge 1 commit into
expressjs:masterfrom
emilioplatzer:master
Closed

emilioplatzer wants to merge 1 commit into
expressjs:masterfrom
emilioplatzer:master

Conversation

@emilioplatzer

Copy link
Copy Markdown

Running npm install I got:

added 373 packages, and audited 374 packages in 18s

74 packages are looking for funding
  run `npm fund` for details

3 high severity vulnerabilities

I updated the packages to their last version an run tests again.

Theres was one test failing locally in my Window 11 machine. It still fails the same way after update.

@socket-security

Copy link
Copy Markdown

@UlisesGascon

Copy link
Copy Markdown
Member

@wesleytodd do you know why the report (View full report↗︎) from socket.dev is private?

Screenshot from 2024-12-21 15-17-12

@UlisesGascon

Copy link
Copy Markdown
Member

Hola @emilioplatzer, thanks for the PR! Currently, serve-index supports very old versions of Node.js, like 0.8, so upgrading dependencies can be challenging. I believe the devDependencies are the ones breaking the CI. Could you remove them from this PR and move them to a separate one?

@wesleytodd

wesleytodd commented Dec 23, 2024

Copy link
Copy Markdown
Member

Hm, I do not know why it is private. I can look into that today.

From the audit report, you can see this is in a dev dep. Additionally it is a redos in a path that is only used to process local markdown files (not in the main exported package). While we would love to get these updated (see @UlisesGascon comments above) it is not considered critical.


trim  <0.0.3
Severity: high
Regular Expression Denial of Service in trim - https://github.com/advisories/GHSA-w5p7-h5w8-2hfq
fix available via `npm audit fix --force`
Will install eslint-plugin-markdown@2.2.1, which is outside the stated dependency range
node_modules/trim
  remark-parse  <=8.0.3
  Depends on vulnerable versions of trim
  node_modules/remark-parse
    eslint-plugin-markdown  <=2.1.0
    Depends on vulnerable versions of remark-parse
    node_modules/eslint-plugin-markdown

@wesleytodd

Copy link
Copy Markdown
Member

@UlisesGascon I checked the settings on the socket side and I think you maybe need to be logged in with your GH account on socket to view it. Maybe there is an option to make it public but I did not see it.

@bjohansebas

Copy link
Copy Markdown
Member

close in favor of #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants