feat: expand editor formatting toolbar and compact menu icons - #58
Merged
Merged
Conversation
exterminatorrat
added this pull request to stack #59
September 17, 2026 15:37
Replace blind yields with the established bounded waitForRuntimeCondition poll and extend the search result deadline to the 5-second convention so the ordinary graph no longer flakes under runner load. Co-authored-by: Harry Jin <harry2028334@concordiashanghai.org>
A transient order-out during an active live-resize drag resigned key and immediately cancelled the drag; the deferred visibility reconcile only cancels now when the window stays hidden, so the documented hide/show-keeps-tracking behavior holds under load. Closing still cancels immediately, and clicking away (visible resign) still cancels. The escape fixture only dispatches to a live tracking session, avoiding the AppKit key-input exception that wedged the enhanced graph. Co-authored-by: Harry Jin <harry2028334@concordiashanghai.org>
The bounded waitForRuntimeCondition helper requires a throwing context, so the lifecycle preemption test now throws like its sibling tests. Co-authored-by: Harry Jin <harry2028334@concordiashanghai.org>
The drag session re-enables the hosted resize through an asynchronous SwiftUI update; a fixed settle can outrun it under runner load and the drag never begins. Probe the track begin with a five-second deadline so the retained-drag fixture stays deterministic. Co-authored-by: Harry Jin <harry2028334@concordiashanghai.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the native editor toolbar while retaining the current measured overflow, trailing Delete, and shared picker/popover handling. This follows #57, now merged into
main, and adapts the reviewed toolbar features onto public source rather than importing the development donor's full ancestry.Add visual text styles, paragraph alignment/spacing/indentation, clear and copied formatting, baseline controls, and Unicode-aware case conversion.
Add guarded web/note links and native in-note find actions. Find shortcuts remain registered with closed overflow or a hidden formatting toolbar: ⌥⌘F, ⇧⌥⌘F, ⌘G, and ⇧⌘G. ⌘F remains workspace search.
Use distinct Text, Paragraph, and Tools icons with one decorative chevron each; retain textual overflow menus, accessible mixed-formatting state, and the existing picker focus behavior.
Preserve attributed selections, real undo/redo, list metadata, canonical image references, and RTF save/reload. Reject stale link targets and attachment-bearing web-link selections; protect unavailable image references during case conversion.
Advance
VERSIONto1.1.2-beta.1, preserving the lower1.0.21-beta.1changelog entry and scrollbar implementation byte-for-byte.Remove the executable-size ceiling per the maintainer's explicit policy decision. Continue reporting executable/helper byte counts and retain all model-asset, symlink, source, UI-string, symbol, signing, identity, and packaging checks.
Verification
9703e37e77f943d558744a76480e5ed513d9a511.Native-window evidence
Enlarged crops of the final Text Style, Text, Paragraph, and Tools controls:
Responsive layouts across light, dark, high-contrast appearance, and reduced-transparency fixtures: