[Asaf-prog]

Adds an opt-in WhatsApp Cloud API channel for one organization-owned number, following the integration plan (WA-01 to WA-05).

Stacked on #148. The base is codex/fix-140-cancelled-token-budget, so this diff shows only the WhatsApp work. GitHub retargets it to main when #148 merges.

Commits

1. test(manager): close SQL engines owned by repository tests. Fixes intermittent aiosqlite worker-thread exceptions in the full gate (task 0018).
2. feat(manager): prepare conversation turns idempotently. An opt-in idempotency key claims a durable receipt with the user message, so a retried preparation recovers the same turn. Migration 0007, ADR 0006.
3. feat(manager): add durable channel storage. Provider-independent inbox, sender bindings, execution claims, webhook receipts, ordered outbox and delivery events, worker ownership, and the channel identity port. Migrations 0008–0010.
4. feat(manager): connect WhatsApp webhook, worker, and delivery. Authenticated webhook intake, a supervised turn worker with conservative recovery, provider delivery with text controls, and /health returning 503 when the worker has stopped. Adds the regex dependency (used by text rendering).
5. docs. ADRs 0007–0010, tasks, and review records.

Rollout

Everything is off by default. Three flags turn it on in order, and settings validation rejects a flag without its prerequisites:

• EXTRA_WHATSAPP_ENABLED: webhook intake.
• EXTRA_WHATSAPP_WORKER_ENABLED: turn worker. Requires intake, an organization id, and an identity resolver plugin.
• EXTRA_WHATSAPP_SENDER_ENABLED: outbound delivery. Requires the worker.

No real account or number has been activated yet. Customer Google/JWT account linking and pilot packaging remain planned.

Validation

• make check passes on the final commit: 1423 tests, plus ruff and mypy.
• Every intermediate commit was checked in a separate worktree for tests, ruff, and mypy: 1126, 1159, 1174, and 1423 tests pass.
• Migrations 0007–0010 need to run on deploy.

🤖 Generated with Claude Code

[Asaf-prog]

1. Summary

Reviewed webhook intake, identity, preparation, execution, delivery, controls, persistence and lifecycle. Synced the latest #148 correction and resolved tasks/README.md while preserving both task lists. One confirmed blocker remains.

2. Blocking issues

Sender-disabled composition bypasses suppression and controls; see the inline finding. In the documented worker-on/sender-off state, /stop becomes failed and a subsequent text invokes the engine and becomes answered. /new also cannot reset in this state.

3. Non-blocking issues

No additional confirmed finding in the inspected paths. Retention and operator reconciliation remain documented follow-ups.

4. Architecture concerns

Manager/provider boundaries and request-scoped identity are preserved; ADRs 0006-0010 document the added contracts. Control enforcement must run independently of outbound transport activation.

5. Security concerns

The reproduced gap permits processing after opt-out, including potential model/tool work. The reproduction used a fake engine and no provider sends. Outbound delivery still has its separate suppression guard.

6. Testing gaps

make check passed on this head: formatting, lint, mypy, 1,432 tests / 27 warnings, and generated-stub checks. A separate real-app TestClient + file-backed SQLite reproduction produced [('stop', 'failed'), ('text', 'answered')] and one engine invocation after /stop. Existing control tests instantiate ChannelControlService directly, missing its absence in sender-disabled composition. Add app-level coverage for suppression and reset with sender disabled, including transition back to live.

7. Suggested improvements

Keep suppression and state-changing controls active whenever the worker runs. Preserve startup without outbound credentials when sender is disabled.

8. Final recommendation

Request changes for the confirmed defect. This is a COMMENT review because the connected account is the PR author and cannot approve its own PR. main also requires independent approval. No main merge was performed.

[Asaf-prog]

[P1] Keep suppression and controls active while sending is paused. ChannelControlService is constructed only inside extra_whatsapp_sender_enabled, so the supported worker-on/sender-off state passes controls=None to ChannelTurnProcessor. Reproduction through create_app/TestClient with file-backed SQLite: POST a signed /stop followed by a signed text; /stop becomes failed and the text becomes answered with one engine invocation. /new also fails to reset. Enforce suppression and state-changing controls whenever the worker runs, independently of transport credentials, and add composition-level regression coverage.