Skip to content

Improve quantity validation message for packing slip #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jishnu-Epics wants to merge 1 commit into from
Closed

Improve quantity validation message for packing slip #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions calicut_textiles/calicut_textiles/doctype/supplier_packing_slip/supplier_packing_slip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ frappe.ui.form.on('Supplier Packing Slip Item', {
add: function(frm, cdt, cdn) {
var item = frappe.get_doc(cdt, cdn);

if (item.qty > item.po_actual_qty) {
frappe.msgprint(__('Quantity is more than in Actual Qty'));
return;
}
if (flt(item.qty) > flt(item.po_actual_qty)) {
frappe.msgprint(__('Quantity cannot be greater than Actual Qty'));
return;
}

if (item.qty <= 0) {
frappe.msgprint(__('Quantity is zero, cannot add a new row.'));
Expand Down
Loading