-
Notifications
You must be signed in to change notification settings - Fork 12
Removed diag/trace estimators, modified example to use skerch, general CI fixes #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andres-fr
wants to merge
12
commits into
f-dangel:main
Choose a base branch
from
andres-fr:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… internal imports. Also added skerch dep and my name to pyproject, and started working on gallery example
…ed in their design). Still working on trace/diag
… other minor linting issues. Now linting, tests and docs all run
Owner
|
Hey, I quickly skimmed through the changes. Could we split up this PR into the following?
|
Collaborator
Author
|
Sure, how do we do this? Should I propose 3 individual PRs? |
Owner
|
Yes 👍 |
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
andres-fr
commented
Jan 6, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main scope of this PR is to address the following issue:
Scope and performance of diagonal approximations #198
Proposed changes in this PR
__rmatmul__to the examples tensor linop to allow for skerch interoperability (shouldn't harm other linops from the core lib)skerchto the test dependenciesAs a result, trace and diagonal estimators are now totally out of the scope of curvlinops, but the gallery example shows that it integrates nicely with skerch, and the errors even got lower!
Additionally, this PR also proposes the following changes, which are not related to the issue above, and I needed in order to properly lint/test the repo and compile the docs:
pytest-optional-testsversion to 0.1.1, newer versions causemake testto crashAs a result, all
makecommands now work from a fresh install on my end (Ubuntu system with CUDA GPU).I managed to do all these changes fast enough to be on top of main HEAD, so although some of them are fundamental and out of scope, hopefully we can land on something that is good for the project. Happy to hear your feedback and adapt!
Also, happy holidays :)
Andres