polish(publications): Brand Navy CTAs, PDF + file-size affordance, kill glassmorphism#21
Open
f1shyfang wants to merge 1 commit into
Open
polish(publications): Brand Navy CTAs, PDF + file-size affordance, kill glassmorphism#21f1shyfang wants to merge 1 commit into
f1shyfang wants to merge 1 commit into
Conversation
…hism
Both download CTAs were labelled "Alternate Link" with identical
accessible names, used bg-blue-600 instead of Brand Navy, and the
glassmorphism disclaimer panel (bg-white/50 backdrop-blur-sm) was on
the DESIGN.md ban list. Generic-marketing copy throughout ("Dive into ...
a must for all", "Packed with helpful tips ... tons of valuable info",
em dash).
Cards rebuilt as the spec token (rounded-xl border border-gray-200
shadow-lg). Primary CTAs renamed "Open PDF" with PDF + file-size
affordance row above each title ("PDF, 24 MB"). Secondary "View on
Google Drive" CTA in Brand Navy ghost style.
PDF-unsupported fallback recoloured from red (suggested error) to
neutral. Disclaimer panel rewritten as standard spec card; italic
removed; promoted to h2 ("A note from the editors") so heading order
makes sense.
Copy rewritten in student-led voice with specific nouns ("course
sequencing notes, elective tips", "internship timelines, resume and
interview notes"). All em dashes removed.
Data hoisted into a typed PUBLICATIONS array so adding a publication
is a one-record change. Added an empty-state card with Brand Navy
contact CTA in case the array is ever empty.
scale transform removed from non-interactive card containers,
transitions made explicit (transition-shadow / transition-colors,
motion-safe guarded). Focus-visible rings on every CTA; aria-labels
on PDF/Drive links naming the document and destination. <object>
aria-label upgraded to "{Title} {Year} embedded preview".
tsc --noEmit: clean. eslint: clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Polish pass on the Next.js /publications page to improve CTA styling/accessibility, simplify maintenance by hoisting publication data into a typed structure, and align layout/styling with updated design direction (including removing blur/glass effects).
Changes:
- Introduced a typed
PUBLICATIONSarray and a reusablePublicationCardrenderer (plus an empty-state card). - Updated download CTAs (labels, destination-aware
aria-labels, and Brand Navy styling) and added a “PDF, size” affordance per publication. - Reworked the disclaimer into a flatter card layout and adjusted motion/hover behavior to be
motion-safeguarded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+192
to
+194
| {publications.map((pub) => ( | ||
| <PublicationCard key={pub.title} publication={pub} /> | ||
| ))} |
Comment on lines
+183
to
188
| <a | ||
| href="/contact" | ||
| className="inline-flex items-center justify-center rounded-lg bg-[#1B397E] px-5 py-2.5 text-sm font-semibold text-white motion-safe:transition-colors motion-safe:duration-200 hover:bg-blue-700 focus:outline-none focus-visible:ring-2 focus-visible:ring-blue-500 focus-visible:ring-offset-2" | ||
| > | ||
| Alternate Link | ||
| Contact CEUS | ||
| </a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish pass on
/publications(single-file page, no client component). Critique score moved from 18/40 → 35/40.Highlights
bg-blue-600instead of Brand Navy, and both were labelled "Alternate Link" with identical accessible names for two different documents. Renamed to "Open PDF" (Brand Navy primary, with PDF + file-size affordance) and "View on Google Drive" (Brand Navy ghost), each with destination-awarearia-label.bg-white/50 backdrop-blur-smis explicitly banned by DESIGN.md. Rebuilt as the spec card token.rounded-xl border border-gray-200 shadow-lg(wasrounded-2xl shadow-xl).PUBLICATIONSarray — adding a publication is now a one-record change. Empty-state card added in case the array is ever empty.motion-safe:guarded.<h3>to<h2>so heading order makes sense.Test plan
npm run dev→/publications— verify both publication cards render with new CTAsprefers-reduced-motion: reduce; verify card hover behavior is shadow-only (no scale)Open question
The current Careers Handbook is the 2023 edition. Either commission a 2026 refresh or relabel the card "2023 edition — refresh in progress." Content decision, not in this PR.
Verification
tsc --noEmit: cleaneslint: cleanMerge note
Independently mergeable. Touches only
CEUS/src/app/publications/page.tsx.🤖 Generated with Claude Code