Fix /analyze/compare 500 (missing created_at_iso)#12
Merged
Conversation
…no meta insert_run derived the NOT NULL created_at_iso from response.meta.timestamp_iso, which analyze() sets but compare() does not — so every /analyze/compare hit failed with 'NOT NULL constraint failed: runs.created_at_iso' (HTTP 500). Fall back to the current UTC time so persistence never depends on response shape. Verified locally: /analyze/compare -> 200 and the run persists to /history. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Live smoke test against https://lyra-ml-api.onrender.com found
POST /analyze/comparereturning 500. Root cause:db.insert_runderives the NOT NULLruns.created_at_isofromresponse["meta"]["timestamp_iso"].analyze()includes ametablock, butcompare()does not — so the insert failed withNOT NULL constraint failed: runs.created_at_iso. (/health,/analyze,/history,/docswere all 200.)Fix
insert_runnow falls back todatetime.now(timezone.utc).isoformat()when the response carries nometatimestamp — persistence no longer depends on the response shape (covers compare and any future mode).Verification (local)
/analyze/compare→ 200; the run persists and shows up in/historywithmode: "compare".🤖 Generated with Claude Code