fix(mobile): register payload + Profile feature-flag gating#4
fix(mobile): register payload + Profile feature-flag gating#4fabiodalez-dev wants to merge 1 commit into
Conversation
…ns on feature flags Two findings from the mobile review: - RegisterRequest (and AuthRepository.register) only sent nome/cognome/email/ password, but the backend AuthController requires telefono, indirizzo, password_confirm and privacy_acceptance — it 422s (privacy_required / missing_fields) otherwise. Add the missing fields (snake_case via @SerialName) so registration matches the contract. - ProfileScreen always showed the Notifications and "Message the library" actions regardless of the instance's `notifications` / `messages` feature flags. Gate them on InstanceFeatures so the app reflects what the library actually exposes via the Mobile API. Verified: ./gradlew :app:compileDebugKotlin BUILD SUCCESSFUL.
|
Warning Review limit reached
More reviews will be available in 2 minutes and 41 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #5 (consolidated Mobile API contract alignment). Changes included there. |
Two P2 findings from the mobile review (no APK distributed yet, so fixed app-side):
1. Registration payload mismatch.
RegisterRequest/AuthRepository.registeronly sent nome/cognome/email/password, but the backendAuthControllerrequires telefono, indirizzo, password_confirm, privacy_acceptance (it 422s withprivacy_required/missing_fieldsotherwise). Added the missing fields (snake_case via@SerialName) so the register call matches the contract.2. Feature-flag gating.
ProfileScreenalways showed the Notifications and Message the library actions regardless of the instance'snotifications/messagesflags. Gated them onInstanceFeatures(read viaLocalServices), so the app reflects what the library actually exposes.Verified:
./gradlew :app:compileDebugKotlin→ BUILD SUCCESSFUL.