Skip to content

fix(mobile): register payload + Profile feature-flag gating#4

Closed
fabiodalez-dev wants to merge 1 commit into
mainfrom
fix/mobile-register-and-feature-gating
Closed

fix(mobile): register payload + Profile feature-flag gating#4
fabiodalez-dev wants to merge 1 commit into
mainfrom
fix/mobile-register-and-feature-gating

Conversation

@fabiodalez-dev

Copy link
Copy Markdown
Owner

Two P2 findings from the mobile review (no APK distributed yet, so fixed app-side):

1. Registration payload mismatch. RegisterRequest / AuthRepository.register only sent nome/cognome/email/password, but the backend AuthController requires telefono, indirizzo, password_confirm, privacy_acceptance (it 422s with privacy_required/missing_fields otherwise). Added the missing fields (snake_case via @SerialName) so the register call matches the contract.

2. Feature-flag gating. ProfileScreen always showed the Notifications and Message the library actions regardless of the instance's notifications/messages flags. Gated them on InstanceFeatures (read via LocalServices), so the app reflects what the library actually exposes.

Verified: ./gradlew :app:compileDebugKotlinBUILD SUCCESSFUL.

…ns on feature flags

Two findings from the mobile review:

- RegisterRequest (and AuthRepository.register) only sent nome/cognome/email/
  password, but the backend AuthController requires telefono, indirizzo,
  password_confirm and privacy_acceptance — it 422s (privacy_required /
  missing_fields) otherwise. Add the missing fields (snake_case via @SerialName)
  so registration matches the contract.

- ProfileScreen always showed the Notifications and "Message the library"
  actions regardless of the instance's `notifications` / `messages` feature
  flags. Gate them on InstanceFeatures so the app reflects what the library
  actually exposes via the Mobile API.

Verified: ./gradlew :app:compileDebugKotlin BUILD SUCCESSFUL.
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fabiodalez-dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 41 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cd4a85af-122c-4445-8c5b-b0bcfa565e11

📥 Commits

Reviewing files that changed from the base of the PR and between 845ae1f and 5b3b9d0.

📒 Files selected for processing (3)
  • app/src/main/java/com/pinakes/app/data/model/Models.kt
  • app/src/main/java/com/pinakes/app/data/repository/AuthRepository.kt
  • app/src/main/java/com/pinakes/app/ui/screens/profile/ProfileScreen.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mobile-register-and-feature-gating

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fabiodalez-dev

Copy link
Copy Markdown
Owner Author

Superseded by #5 (consolidated Mobile API contract alignment). Changes included there.

@fabiodalez-dev fabiodalez-dev deleted the fix/mobile-register-and-feature-gating branch June 25, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant