feat: validate signed webhook ingestion - #6
Merged
Conversation
Define the raw-body HMAC, replay window, payload digest, and bounded idempotency metadata before transport integration. Refs #5
Verify the exact raw body against encrypted endpoint signing material and reject stale, malformed, disabled, or oversized requests safely. Refs #5
Keep numeric serialization explicit and use the repository lookup as the endpoint-state guard. Refs #5
Document the raw signing contract, scope boundary, validation evidence, and public review state. Refs #5
Return a stable internal error without blaming request validation or exposing the underlying server cause. Refs #5
Keep main accurate after the authorized merge and route the next session to a separate WOP-103 issue. Refs #5
fabiorosa
marked this pull request as ready for review
July 29, 2026 03:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
types, payload shapes, endpoint states, signatures, and sizes
Why
AfterHook needs a defensible ingestion boundary before event persistence or
delivery exists. Keeping this slice transport-focused makes the raw HTTP and
cryptographic contract independently reviewable. WOP-103 will own authoritative
event creation and duplicate resolution.
Validation
npm run qualitypassed locally on WindowsCloses #5