perf(python): rewrite hot Seq combinators as native Python generators#4728
Open
MangelMaxime wants to merge 1 commit into
Open
perf(python): rewrite hot Seq combinators as native Python generators#4728MangelMaxime wants to merge 1 commit into
MangelMaxime wants to merge 1 commit into
Conversation
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
95d196d to
74a576c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's
Seqcombinators built ongenerate/Enumerator.generateWhileSome: anOptionallocated per element, plus aMoveNext/Currentcall per step - a faithful port of F#'sIEnumerable/IEnumeratormodel, but on CPython the per-element object churn dominates.Benchmark
Compiled a pipeline exercising several of the converted combinators together (
map,choose,map2,takeWhile,tryItem,fold- not justmap/filter/collect), before vs after,5,000 calls:
Results identical both runs:
69360.A simpler
map/filter/collect/foldpipeline measured separately shows ~1.7x.