You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move core source ownership into packages/core/src so @fabricjs/core builds from its own workspace source instead of depending on the root implementation layout.
Move the current core implementation tree from root src/* into packages/core/src/* and move fabric.ts exports into packages/core/src/index.ts.
Update package imports, tsconfig paths, rolldown inputs, and build/package scripts so @fabricjs/core builds like a normal workspace package.
Keep the root entrypoints as compatibility facades for now and preserve existing import/export names and behavior.
Remove the special core dist staging flow and point package smoke/build expectations at the package-owned source and output.
This was more complicated than i thought, and i need to test it properly.
I don't think i want to maintain the old import { Canvas } from 'fabric' as soon as this one is ready. Too much noise in my opinion
This was more complicated than i thought, and i need to test it properly. I don't think i want to maintain the old import { Canvas } from 'fabric' as soon as this one is ready. Too much noise in my opinion
we could release new major and say what are the new entrypoints?
Base automatically changed from
divide-packages-more-step3 to
masterJuly 8, 2026 09:08
This was more complicated than i thought, and i need to test it properly. I don't think i want to maintain the old import { Canvas } from 'fabric' as soon as this one is ready. Too much noise in my opinion
we could release new major and say what are the new entrypoints?
I think we want to do at least one last version in which i publish both, so i test everything ends up being the same, before putting out a new major i want to be sure all examples on fabricjs.com import from the new package, so i m confident things just work
@Smrtnyk this is fully broken i had an hard week and couldn't look into it, i hope i can do this weekend so i unblock the repo.
no worries, I noticed that build is red and that you have to do more changes
just put my approval as a signal that I am watching the progress on monorepo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move core source ownership into
packages/core/srcso@fabricjs/corebuilds from its own workspace source instead of depending on the root implementation layout.src/*intopackages/core/src/*and movefabric.tsexports intopackages/core/src/index.ts.@fabricjs/corebuilds like a normal workspace package.master.related to #10894