Guard against empty input in chunk_markdown()#5
Merged
fabriziosalmi merged 1 commit intoJun 6, 2026
Conversation
The function currently proceeds to split an empty string into sections, which results in a single empty chunk that is then filtered out by the `min_chars` check. This triggers unnecessary regex compilation and list processing for no gain. Adding an early return for empty input improves performance and prevents the creation of transient empty state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FabGPT — code quality
File:
agent/rag/chunker.pyRationale: The function currently proceeds to split an empty string into sections, which results in a single empty chunk that is then filtered out by the
min_charscheck. This triggers unnecessary regex compilation and list processing for no gain. Adding an early return for empty input improves performance and prevents the creation of transient empty state.Proposed by FabGPT OS and approved by a human before opening.
🤖 FabGPT OS · source
quality· modelqwen/qwen3.5-9b· task28fd64433c92ead9· HITL-approved before opening.