Guard against empty git output to prevent invalid hash#4
Merged
fabriziosalmi merged 1 commit intoJun 6, 2026
Merged
Conversation
The current logic uses `trim()` on the git output, which will result in an empty string if the git command fails or returns no output (e.g., in a fresh repo with no commits). This causes the binary version to be 'unknown' instead of a valid fallback, potentially breaking version parsing logic in the application. Adding an explicit check for empty strings ensures the fallback 'unknown' is only used when no hash data exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FabGPT — code quality
File:
build.rsRationale: The current logic uses
trim()on the git output, which will result in an empty string if the git command fails or returns no output (e.g., in a fresh repo with no commits). This causes the binary version to be 'unknown' instead of a valid fallback, potentially breaking version parsing logic in the application. Adding an explicit check for empty strings ensures the fallback 'unknown' is only used when no hash data exists.Proposed by FabGPT OS and approved by a human before opening.
🤖 FabGPT OS · source
quality· modelqwen/qwen3.5-9b· taskf345b090f19623f1· HITL-approved before opening.