Skip to content

Add Qwen3.8 Max to OpenRouter - #720

Draft
brynary wants to merge 1 commit into
mainfrom
codex/add-qwen3-8-max-openrouter
Draft

Add Qwen3.8 Max to OpenRouter#720
brynary wants to merge 1 commit into
mainfrom
codex/add-qwen3-8-max-openrouter

Conversation

@brynary

@brynary brynary commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

  • add Qwen3.8 Max to the built-in OpenRouter model catalog
  • record its context and output limits, multimodal and reasoning capabilities, prompt-cache pricing, and supported reasoning levels
  • add a focused catalog snapshot test

Sources

Testing

  • cargo +nightly-2026-04-14 fmt --check --all
  • cargo nextest run -p fabro-model
  • cargo +nightly-2026-04-14 clippy -p fabro-model --all-targets -- -D warnings
  • git diff --check

Copilot AI review requested due to automatic review settings August 3, 2026 20:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Qwen3.8 Max to the built-in OpenRouter model catalog in fabro-model, including limits, capabilities, reasoning controls, and pricing metadata, plus a targeted snapshot test to guard the catalog entry.

Changes:

  • Added the qwen3.8-max OpenRouter catalog entry with context/max-output limits, feature flags (tools/vision/reasoning/prompt-cache), reasoning-effort levels, and pricing.
  • Added a focused unit test + insta debug snapshot to ensure the model is present when OpenRouter is enabled and that key settings (api_id, reasoning defaults, controls) match expectations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/foundation/fabro-model/src/catalog/providers/openrouter.toml Adds the qwen3.8-max model definition (limits, features, controls, costs) to the OpenRouter built-in catalog.
lib/foundation/fabro-model/src/catalog.rs Adds an insta snapshot test ensuring the new OpenRouter model is included and its settings are correct when enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants