Add Qwen3.8 Max to OpenRouter - #720
Draft
brynary wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Qwen3.8 Max to the built-in OpenRouter model catalog in fabro-model, including limits, capabilities, reasoning controls, and pricing metadata, plus a targeted snapshot test to guard the catalog entry.
Changes:
- Added the
qwen3.8-maxOpenRouter catalog entry with context/max-output limits, feature flags (tools/vision/reasoning/prompt-cache), reasoning-effort levels, and pricing. - Added a focused unit test +
instadebug snapshot to ensure the model is present when OpenRouter is enabled and that key settings (api_id, reasoning defaults, controls) match expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/foundation/fabro-model/src/catalog/providers/openrouter.toml | Adds the qwen3.8-max model definition (limits, features, controls, costs) to the OpenRouter built-in catalog. |
| lib/foundation/fabro-model/src/catalog.rs | Adds an insta snapshot test ensuring the new OpenRouter model is included and its settings are correct when enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sources
Testing