Skip to content

Extend iOS xcrun xctrace profiling to handle other types #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KarlSimonsen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extend iOS xcrun xctrace profiling to handle other types #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions benchmarking/platforms/ios/ios_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,17 @@ def runBenchmark(self, cmd, *args, **kwargs):
if platform_args.get("profiling_args", {}).get("enabled", False):
# attempt to run with profiling, else fallback to standard run
try:
profiling_types = platform_args["profiling_args"]["types"]
options = platform_args["profiling_args"]["options"]
args = " ".join(["--" + x + " " + arguments[x] for x in arguments])
xctrace = getProfilerByUsage(
"ios",
None,
platform=self,
model_name=platform_args.get("model_name", None),
args=args,
types=profiling_types,
options=options,
)
if xctrace:
f = xctrace.start()
Expand All @@ -137,9 +141,8 @@ def runBenchmark(self, cmd, *args, **kwargs):
)
return output, meta
except Exception:
getLogger().critical(
f"An error occurred when running XCTrace profiler on device {self.platform} {self.platform_hash}.",
exc_info=True,
getLogger().exception(
f"An error occurred when running XCTrace profiler on device {self.platform} {self.platform_hash}."
)
# meta is used to store any data about the benchmark run
# that is not the output of the command
Expand Down