Conversation
lucamegh
commented
Feb 14, 2026
| dependencies: [ | ||
| "QuickLayoutMacro", | ||
| .target(name: "QuickLayoutBridge", condition: .when(platforms: [.iOS, .macCatalyst])), | ||
| .target(name: "QuickLayoutBridge", condition: .when(platforms: [.iOS, .macCatalyst, .visionOS])), |
Contributor
Author
There was a problem hiding this comment.
Shouldn't .macOS be added here as well?
Contributor
There was a problem hiding this comment.
Don't think so. QuickLayoutBridge uses UIKit, so it won't compile on macOS.
lucamegh
commented
Feb 14, 2026
| dependencies: [ | ||
| "FastResultBuilder", | ||
| .target(name: "QuickLayoutCore", condition: .when(platforms: [.iOS, .macCatalyst])), | ||
| .target(name: "QuickLayoutCore", condition: .when(platforms: [.iOS, .macCatalyst, .visionOS])), |
Contributor
There was a problem hiding this comment.
Could be done with a refactoring but QuickLayoutCore has few dependencies to UIKit.
lucamegh
commented
Feb 14, 2026
| } | ||
| } | ||
| #endif | ||
| return scale |
Contributor
Author
There was a problem hiding this comment.
Since there no equivalent to UIScreen.scale on visionOS, it's reasonable to return 1.0.
|
@constantine-fry has imported this pull request. If you are a Meta employee, you can view this in D93882203. |
|
@constantine-fry merged this pull request in 56da492. |
Contributor
|
@lucamegh thank you for making the pull request. Much appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.