docs: distill Table plugin/hook review patterns into the package reviewer#3798
Merged
Conversation
… package reviewer
cixzhang
requested review from
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
July 11, 2026 03:28
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
josephfarina
approved these changes
Jul 11, 2026
… from review history
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Distills recurring, generalizable patterns from recent review history into the package Copilot reviewer, so it catches them automatically next time. Advisory, as with the rest of the reviewer.
From the Table plugin series (#3756, #3757, #3763)
Plugins & hooks that extend a host component:
Tableplugin should accept the sameidKey(string-or-getter) and name outputs to match the host's props (idKey, notgetRowKey).color: 'accent'), not raw values.startFromthat changesaria-rowindex) likely belongs on the host.Hook stability & reuse of existing data:
datato recompute what the row already carried asaria-rowindex.From wider review history (#3665, #3721)
<div>for styling (Mechanical checklist) — Astryx components extendBaseProps(takexstyle), so apply style directly (<Divider xstyle={...} />) instead of wrapping in a styled div.Why
These came up repeatedly across real PRs. Encoding them means the reviewer surfaces API-consistency, hook-stability, wrapper-div, and subtle-breaking-change issues on the next PR instead of relying on a maintainer to re-notice each time.
I deliberately left out one-off nits (test-enumeration asks, "reuse this later" praise, in-progress perf musings) that don't generalize into a rule.