fix(lab): replace hardcoded spacing in Stepper with spacing tokens#4189
Open
cixzhang wants to merge 1 commit into
Open
fix(lab): replace hardcoded spacing in Stepper with spacing tokens#4189cixzhang wants to merge 1 commit into
cixzhang wants to merge 1 commit into
Conversation
Stepper.tsx used a raw '2px' gap value and Step.tsx used a raw '4px' bar width. Replace with spacingVars['--spacing-0-5'] and spacingVars['--spacing-1'] respectively so the values participate in theme spacing scales.
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded spacing values in the Stepper component (lab) with spacing token references.
Changes:
Stepper.tsx: replaced raw'2px'gap constant withspacingVars['--spacing-0-5']Step.tsx: replaced raw'4px'bar width constant withspacingVars['--spacing-1']These values now participate in the theme spacing scale, matching the convention used by all other lab and core components. No visual change at default theme values (2px and 4px are the resolved defaults for those tokens).
Testing:
pnpm buildclean, all 19 Stepper tests pass.Night Watch -- Component Auditor