feat(Stepper): on-track indicator position + status iconography (EPS parity)#4214
Merged
Conversation
…or EPS parity Harden the lab Stepper toward the EPS migration (#4181). - Add `indicatorPosition` prop ("separated" default | "on-track"). On-track slots indicators between continuous track segments to match EPS; the whole indicator+label is the click target, and the trailing segment is hidden on the last step (via stepCount from context). - Status now drives indicator iconography instead of recoloring the track: track lines always stay the progress accent; `success`/`warning`/`error` swap the glyph (themed status icons), and the current-step ring always wins. Completed steps keep the filled circle-check to stay distinct from `success`. - Density applies around the indicators (not just the label) in on-track. - Left-align vertical/on-track descriptions; fix description line-height (16px). - Stories + tests for on-track layout and status glyph precedence. Co-authored-by: Cursor <cursoragent@cursor.com>
ernestt
requested review from
cixzhang,
ejhammond and
imdreamrunner
as code owners
July 22, 2026 21:48
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the lab
Steppertoward the EPS migration (facebook/astryx#4181).indicatorPositionprop —"separated"(default) |"on-track". On-track slots each indicator between continuous track segments (EPS style) rather than beside a per-step bar. The whole indicator+label is the click target, and the trailing segment is hidden on the last step (stepCountthreaded via context).success/warning/errorswap the indicator glyph (themed status icons, matchingInput), and the current-step ring always takes precedence. Completed steps keep the filled circle-check so they stay visually distinct fromsuccess. Not-started steps stay neutral regardless of status.On-track variant: known cons (accepted for EPS parity)
on-trackships because it is a non-negotiable EPS migration requirement (#4181), not because it's the more robust layout.separatedremains the default and the recommended general-purpose variant. Reviewers should be aware of the on-track trade-offs baked into this design:indicator="none"is meaningless on-track. The node is what "sits on the track"; with no node you get a bare line plus an empty rail column offsetting the labels — all the layout cost, none of the payoff. Legitimate inseparated.separated's uniform per-step padding.stepCountfrom context to hide the last trailing segment — theseparatedvariant needs none of this.endContent/ content slot align less tidily, since labels are offset from the rail (vertical) or centered (horizontal).separatedvariant.separatedvariant.A truly continuous rail running under the nodes (vs. segments flanking each node) would require restructuring the connector into a single overlay layer with absolutely-positioned nodes; that's intentionally out of scope here.
Test plan
pnpm -F @astryxdesign/lab typecheckvitest run packages/lab/src/Stepper/Stepper.test.tsx(24 passing)lab-stepper— Separated (default), OnTrackVertical, OnTrackHorizontalDescriptions, StatusAllStates, OnTrackStatusInputand current-step ring wins over statusstatusMade with Cursor