Re-export implicitly public types lost in TS auto-generation#1672
Open
Re-export implicitly public types lost in TS auto-generation#1672
Conversation
Summary: Fix: #1671 Auto-generation of TS types dropped some hand-written exports that were never exported in Flow, so that upgrading from 0.83.3 to 0.83.5 broke some (advanced) users' TS imports. This restores the ones that were already implicitly part of the public API anyway. Changelog: ``` - **[Types]**: Restore type exports from `metro` that were previously TypeScript-specific ``` Differential Revision: D97315670
meta-cla
bot
added
the
CLA Signed
Contributor
Contributor
Author
|
CC @tido64 for whether this covers the exports you found to be broken. |
Contributor
|
@robhogan Thanks! I've tested this locally and it seems to be working fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix: #1671
Auto-generation of TS types dropped some hand-written exports that were never exported in Flow, so that upgrading from 0.83.3 to 0.83.5 broke some (advanced) users' TS imports.
This restores the ones that were already implicitly part of the public API anyway.
Changelog:
Differential Revision: D97315670