[postcss-plugin] Fix importSource object syntax not working properly#1065
Merged
Conversation
Merged
1 task
necolas
approved these changes
May 17, 2025
necolas
left a comment
Contributor
There was a problem hiding this comment.
We need unit tests for this plugin
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Using the
{ from, as }object form in importSources caused a runtime error due to incorrect .includes usage in Previous PR. This fix ensures both string and object forms are handled properly in shouldTransform.Linked PR/Issues
#1063
Additional Context
In main branch, move to the example app
cd examples/example-nextjsUsing the object syntax throws when running
npm run example:dev:Switch to this branch and now it does not throw and renders correctly.
Pre-flight checklist
Contribution Guidelines