Migrate wangle generate_cmake.py to shared library + add select() support#251
Closed
afrind wants to merge 1 commit intofacebook:mainfrom
Closed
Migrate wangle generate_cmake.py to shared library + add select() support#251afrind wants to merge 1 commit intofacebook:mainfrom
afrind wants to merge 1 commit intofacebook:mainfrom
Conversation
…port Summary: - Import shared parsing functions from opensource.buck_to_cmake.buck_parser instead of reimplementing extract_list, extract_external_deps, write_cmake_file - Add select() support for deps/exported_deps using generate_select_deps_block - Regenerate wangle/acceptor/CMakeLists.txt with newly discovered dep (Folly::folly_io_async_fdsock_async_fd_socket from select() branch) Differential Revision: D95579502
|
This pull request has been merged in f0c16a0. |
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 8, 2026
…port Summary: X-link: facebook/wangle#251 - Import shared parsing functions from opensource.buck_to_cmake.buck_parser instead of reimplementing extract_list, extract_external_deps, write_cmake_file - Add select() support for deps/exported_deps using generate_select_deps_block - Regenerate wangle/acceptor/CMakeLists.txt with newly discovered dep (Folly::folly_io_async_fdsock_async_fd_socket from select() branch) Reviewed By: yfeldblum Differential Revision: D95579502 fbshipit-source-id: 9f1456b97bd13f3b334327dfbef9470595710273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
instead of reimplementing extract_list, extract_external_deps, write_cmake_file
(Folly::folly_io_async_fdsock_async_fd_socket from select() branch)
Differential Revision: D95579502