mcp: send background progress logs in the data parameter - #90
Merged
rikvanriel merged 1 commit intoSep 18, 2026
Merged
rikvanriel merged 1 commit into
rikvanriel merged 1 commit into
Conversation
The background indexing task reports its progress with
notifications/message, and none of those messages reach the client. The
parameters of that notification are level, logger and data, and the
payload builds them with a message key instead, so data is absent.
A client that validates incoming notifications rejects the payload and
drops it, which leaves the indexing progress invisible and puts a warning
and a traceback in the client log for every progress line:
pydantic_core._pydantic_core.ValidationError: 1 validation error for LoggingMessageNotification
params.data
Field required [type=missing, input_value={'level': 'info', 'messag...Indexing complete'}, input_type=dict]
Build the payload with data, the parameter the notification defines for
the logged text.
Fixes: a58b5b6 ("semcode-mcp: add indexing visibility and status reporting")
Assisted-by: Hermes:openrouter-auto
Signed-off-by: Rik van Riel <riel@surriel.com>
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background indexing task reports its progress with notifications/message, and none of those messages reach the client. The parameters of that notification are level, logger and data, and the payload builds them with a message key instead, so data is absent.
A client that validates incoming notifications rejects the payload and drops it, which leaves the indexing progress invisible and puts a warning and a traceback in the client log for every progress line:
Build the payload with data, the parameter the notification defines for the logged text.
Fixes: a58b5b6 ("semcode-mcp: add indexing visibility and status reporting")
Assisted-by: Hermes:openrouter-auto