Add GCC 16 and Clang 22 + libc++ jobs, and cover examples in CI (#82) - #82
Closed
graphicsMan wants to merge 1 commit into
Closed
graphicsMan wants to merge 1 commit into
graphicsMan wants to merge 1 commit into
Conversation
Contributor
|
@graphicsMan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117385115. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
- Coverage 92.9% 92.7% -0.3%
=======================================
Files 64 64
Lines 4990 4990
Branches 682 681 -1
=======================================
- Hits 4638 4628 -10
- Misses 352 362 +10 🚀 New features to boost your workflow:
|
graphicsMan
force-pushed
the
export-D117385115
branch
from
August 26, 2026 08:08
a1be58a to
e99b37f
Compare
graphicsMan
force-pushed
the
export-D117385115
branch
from
August 26, 2026 09:29
e99b37f to
5771176
Compare
…bookincubator#82) Summary: Neither runner image ships anything newer than GCC 13, so these are the only coverage of current compilers -- and, as it turns out, the only jobs that build `examples/` at all. Sixteen example programs, including the one the README links as "try it live", were never compiled by CI and could rot unnoticed. - **Linux GCC 16 + libstdc++**, from the Docker official image, so it is the compiler a user gets rather than whatever the runner ships. - **Linux Clang 22 + libc++**, from LLVM's own apt repo. libc++ is deliberate: every other Linux job uses libstdc++, and the existing clang-trunk job already covers Clang against it, so this is the only configuration exercising a second standard library. Both also compile an installed prefix as an external consumer -- plain `-I`, no CMake target. That is what packagers ship and what broke in 1.6.1, and nothing else in CI covers it; `release.py preflight` does, but only at release time, which is the most expensive moment to find out. Blocking rather than advisory, because an example that stops compiling should fail CI. Both toolchains are pinned, so neither can change under us. This replaces the advisory GCC 15.3/16.2 pair from the previous version. Those existed to reproduce a -Wstringop-overflow report and did not: the warning comes from Compiler Explorer's own GCC builds, not from the upstream ones, and the same versions here are clean. It is moodycamel's, reported upstream as cameron314/concurrentqueue#456 with a self-contained reproduction. Keeping two jobs to chase it would have been coverage theatre. Also adds `examples/chunking_comparison_example.cpp` -- the program the README links -- so it is compiled on every run rather than living only in a Godbolt shortlink. Differential Revision: D117385115
graphicsMan
force-pushed
the
export-D117385115
branch
from
August 26, 2026 09:40
5771176 to
314b1d2
Compare
Contributor
|
This pull request has been merged in d74898a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Neither runner image ships anything newer than GCC 13, so these are the only
coverage of current compilers -- and, as it turns out, the only jobs that build
examples/at all. Sixteen example programs, including the one the README linksas "try it live", were never compiled by CI and could rot unnoticed.
compiler a user gets rather than whatever the runner ships.
every other Linux job uses libstdc++, and the existing clang-trunk job already
covers Clang against it, so this is the only configuration exercising a second
standard library.
Both also compile an installed prefix as an external consumer -- plain
-I, noCMake target. That is what packagers ship and what broke in 1.6.1, and nothing
else in CI covers it;
release.py preflightdoes, but only at release time,which is the most expensive moment to find out.
Blocking rather than advisory, because an example that stops compiling should
fail CI. Both toolchains are pinned, so neither can change under us.
This replaces the advisory GCC 15.3/16.2 pair from the previous version. Those
existed to reproduce a -Wstringop-overflow report and did not: the warning comes
from Compiler Explorer's own GCC builds, not from the upstream ones, and the
same versions here are clean. It is moodycamel's, reported upstream as
cameron314/concurrentqueue#456 with a self-contained reproduction. Keeping two
jobs to chase it would have been coverage theatre.
Also adds
examples/chunking_comparison_example.cpp-- the program the READMElinks -- so it is compiled on every run rather than living only in a Godbolt
shortlink.
Differential Revision: D117385115