Include tsan_annotations.h so the TSAN guard in timing_test works - #85
Merged
Merged
Conversation
timing_test.cpp wraps its whole body in #if !DISPENSO_HAS_TSAN, but that macro is defined in dispenso/tsan_annotations.h, which the file never includes. The macro has therefore always been undefined, !0 always true, and the guard has never excluded anything -- the timing tests have been compiled in under TSAN since the file was added. Adding the include restores the intended behaviour. Nothing changes outside TSAN builds.
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
+ Coverage 92.6% 92.8% +0.1%
=======================================
Files 64 64
Lines 4990 4990
Branches 678 680 +2
=======================================
+ Hits 4625 4632 +7
+ Misses 365 358 -7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88.
tests/timing_test.cppwraps its entire body in#if !DISPENSO_HAS_TSAN, with acomment explaining that timing assertions are too sensitive to instrumentation
to be meaningful under ThreadSanitizer.
DISPENSO_HAS_TSANis defined indispenso/tsan_annotations.h, which the testnever includes. The macro is therefore always undefined,
!0is always true,and the guard has never excluded anything — the timing tests have been running
under TSAN since the file was added.
Adding the include restores the intended behaviour. Nothing changes outside
TSAN builds.
This is invisible in the normal build because the CMake configuration does not
warn on undefined macros in
#if. Building with-Wundefsurfaces it.