Skip to content

Fix requirements parsing and declare Python >= 3.9 - #2219

Open
SY-Jia06 wants to merge 1 commit into
facebookresearch:mainfrom
SY-Jia06:codex/fix-setup-requires
Open

Fix requirements parsing and declare Python >= 3.9#2219
SY-Jia06 wants to merge 1 commit into
facebookresearch:mainfrom
SY-Jia06:codex/fix-setup-requires

Conversation

@SY-Jia06

@SY-Jia06 SY-Jia06 commented Feb 8, 2026

Copy link
Copy Markdown

Motivation and Context

setup.py previously split requirements.txt verbatim, which includes comment lines. Those can be interpreted as invalid requirements during pip install -e habitat-lab. This change filters comments/blank lines, updates the Python badge to 3.9, and declares python_requires>=3.9 for consistent packaging metadata.

How Has This Been Tested

Not run (packaging metadata only).

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)
  • [Docs change] (badge update)

@meta-cla

meta-cla Bot commented Feb 8, 2026

Copy link
Copy Markdown

Hi @SY-Jia06!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 8, 2026
@meta-cla

meta-cla Bot commented Feb 8, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SY-Jia06

SY-Jia06 commented Feb 8, 2026

Copy link
Copy Markdown
Author

Small packaging fix, ready for review. No runtime changes.

@wadeKeith wadeKeith left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawn; this review was too cursory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants