--[WIP][Bugfix]- Address remaining issues with bindings stubgen - #2432
Merged
Conversation
jturner65
force-pushed
the
Bindings2_Fixes
branch
2 times, most recently
from
July 25, 2024 15:26
de33659 to
9edf16e
Compare
jturner65
force-pushed
the
Bindings2_Fixes
branch
from
August 9, 2024 21:01
9edf16e to
2e86411
Compare
Using python keywords as arg names causes the generated stubs to fail; Use standard binding protocol.
jturner65
force-pushed
the
Bindings2_Fixes
branch
from
August 13, 2024 14:01
2e86411 to
d4e83c1
Compare
jturner65
marked this pull request as ready for review
August 13, 2024 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes some issues that were missed in the previous PR, which manifest when pybind11 stubs are being generated (see here ).
Until all such issues are fixed, adding pybind11-stubgen to the build process will generate a stub file that will fail mypy precommit. In other words, no python source code changes or additions will be able to be committed to the repo with the erroneous stub file.
Also, some missed spelling errors are corrected.
How Has This Been Tested
Locally tests pass; also testing with mypy execution on a modified python file.
Types of changes
Checklist