Fix SemanticLevel.objects always empty for MP3D scenes - #2640
Open
Functionhx wants to merge 1 commit into
Open
Conversation
Objects were added to regions but never propagated to the parent level's objects vector. This caused SemanticLevel.objects to always return an empty list, even though objects were correctly accessible through SemanticRegion.objects. Test Plan: - Load an MP3D house file and verify SemanticLevel.objects is non-empty - Verify the fix works both via SemanticScene.load_mp3d_house() and through the Simulator Fixes facebookresearch#2597
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2597.
Objects were added to regions but never propagated to the parent level's
objects vector. This caused SemanticLevel.objects to always return an
empty list, even though objects were correctly accessible through
SemanticRegion.objects.
The fix adds 2 lines in Mp3dSemanticScene.cpp to also push each object
onto the parent level's objects vector when the object's region has a
parent level.