Skip to content

Save 25% of memory usage on vertex position buffer (PTex Mesh) #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigbike merged 5 commits into from
Dec 2, 2019
Merged

Save 25% of memory usage on vertex position buffer (PTex Mesh) #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40a400c
Save 25% of memory usage on vertex position buffer
bigbike Nov 12, 2019
8bfd26d
Merge branch 'master' into pos
bigbike Nov 18, 2019
2d264f8
Merge branch 'master' into pos
bigbike Nov 18, 2019
9db9d4b
minor
bigbike Nov 18, 2019
5be86cb
Merge branch 'master' into pos
bigbike Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/esp/assets/PTexMeshData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,9 +667,12 @@ void PTexMeshData::parsePLY(const std::string& filename,
CORRADE_ASSERT(positionDimensions > 0,
"PTexMeshData::parsePLY: the dimensions of the position is "
"not greater than 0", );
CORRADE_ASSERT(
positionDimensions == 3,
"PTexMeshData::parsePLY: the dimensions of the position must be 3.", );
}

meshData.vbo.resize(numVertices, vec4f(0, 0, 0, 1));
meshData.vbo.resize(numVertices, vec3f(0, 0, 0));

@msbaines msbaines Nov 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should assert that positionDimensions < 4.


if (normalDimensions) {
meshData.nbo.resize(numVertices, vec4f(0, 0, 0, 1));
Expand Down
2 changes: 1 addition & 1 deletion src/esp/assets/PTexMeshData.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace assets {
class PTexMeshData : public BaseMesh {
public:
struct MeshData {
std::vector<vec4f> vbo;
std::vector<vec3f> vbo;
std::vector<vec4f> nbo;

@msbaines msbaines Nov 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't nbo also be a vec3?

@mosra mosra Nov 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, neither nbo nor cbo is used right now (only populated). Is that correct?

@bigbike bigbike Nov 13, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, neither nbo nor cbo is used right now (only populated). Is that correct?

Yes, you are right. I checked them as well before this PR.

std::vector<vec4uc> cbo;
std::vector<uint32_t> ibo;
Expand Down
2 changes: 1 addition & 1 deletion src/esp/gfx/PTexMeshShader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace gfx {
class PTexMeshShader : public Magnum::GL::AbstractShaderProgram {
public:
//! @brief vertex positions
typedef Magnum::GL::Attribute<0, Magnum::Vector4> Position;
typedef Magnum::GL::Attribute<0, Magnum::Vector3> Position;

/**
* @brief Constructor
Expand Down